[FFmpeg-devel] [WIP][RFC][PATCH] avcodec: add IMM4 decoder

[Rostislav Pehlivanov]

On Sat, 11 Aug 2018 at 13:24, Paul B Mahol <onemda at gmail.com> wrote:

> Hi,
>
> Much improved and cleaned up version attached.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


> +    INIT_VLC_SPARSE_STATIC(&cbplo_tab, 9, FF_ARRAY_ELEMS(cbplo_bits),
> +                           cbplo_bits, 1, 1, cbplo_codes, 1, 1, cbplo_symbols, 1, 1, 512);
> +
> +    INIT_VLC_SPARSE_STATIC(&cbphi_tab, 6, FF_ARRAY_ELEMS(cbphi_bits),
> +                           cbphi_bits, 1, 1, cbphi_codes, 1, 1, NULL, 0, 0, 64);
> +
> +    INIT_VLC_SPARSE_STATIC(&blktype_tab, 9, FF_ARRAY_ELEMS(blktype_bits),
> +                           blktype_bits, 1, 1, blktype_codes, 1, 1, blktype_symbols, 1, 1, 512);
> +
> +    INIT_VLC_SPARSE_STATIC(&block_tab, 12, FF_ARRAY_ELEMS(block_bits),
> +                           block_bits, 1, 1, block_codes, 1, 1, block_symbols, 2, 2, 4096);

Don't you need to wrap this in a separate init function and call it
from ff_thread_once()? I'd prefer if you just put cbplo_tab inside the
main context, but I don't mind them being global.