[FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

[Carl Eugen Hoyos]

2018-08-14 9:57 GMT+02:00, Gyan Doshi <gyandoshi at gmail.com>:
>
>
> On 14-08-2018 01:20 PM, Paul B Mahol wrote:
>> On 8/14/18, Gyan Doshi <gyandoshi at gmail.com> wrote:
>>>
>>>
>>> On 14-08-2018 03:24 AM, Carl Eugen Hoyos wrote:
>>>
>>>>>>
>>>>>> Why does this not use -filter_threads?
>>>>>
>>>>>
>>>>> Didn't know it was an option.
>>>>
>>>>> I can certainly change the code to use it.
>>>>
>>>> Please do it if it works.
>>>
>>> filter_threads applies to all simple filtergraphs. The private option
>>> is specifically targeted. Isn't that better?

I believe the opposite is true.

>> filter_threads is used only for internal threading, so using it for
>> something external seems wrong.

Like the libavcodec option -threads?

> I also realized that libvmaf requires two inputs and should/will be used
> within a complex filtergraph so -filter_threads wouldn't apply even if
> wanted.

Isn't it a bug that -filter_threads does not apply for -filter_complex?

Carl Eugen