[FFmpeg-devel] [PATCH] lavc/hevc_ps: fix crop info for monochrome

Michael Niedermayer michael at niedermayer.cc
Wed Aug 22 03:26:47 EEST 2018


On Mon, Aug 20, 2018 at 10:19:04AM +0800, Zhao Zhili wrote:
> 
> 
> On 2018年08月18日 05:33, Michael Niedermayer wrote:
> >On Fri, Aug 17, 2018 at 09:52:57AM +0800, Zhao Zhili wrote:
> >>The values of SubWidthC and SubHeightC are 1 in the ITU-T H.265. The
> >>current code use the value of 2.
> >>---
> >>  libavcodec/hevc_ps.c | 16 ++++++++++++----
> >>  1 file changed, 12 insertions(+), 4 deletions(-)
> >>
> >>diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c
> >>index fbd9fbf..b56b078 100644
> >>--- a/libavcodec/hevc_ps.c
> >>+++ b/libavcodec/hevc_ps.c
> >>@@ -70,6 +70,14 @@ static const AVRational vui_sar[] = {
> >>      {  2,   1 },
> >>  };
> >>+static const unsigned hevc_sub_width_c[] = {
> >uint8_t saves a few bytes
> >
> >more important, the commit message should mention a ticket or test sample
> >also a fate test with a _small_ testsample would be usefull. Obviously
> >the existing tests do not cover this
> >
> 
> The bug was found by reading the source code. There is no ticket
> related to the bug. I need some time to download the test suite
> and figure out how it work. Feel free to add the test if anyone
> has a suitable sample.

if theres no test sample, creating one would be a good idea so this
is tested. Because as is it would be a change that completely untested

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180822/8dad0a17/attachment.sig>


More information about the ffmpeg-devel mailing list