[FFmpeg-devel] [PATCH 1/9] configure: [loongson] revert no-expensive-optimizations

Shiyou Yin yinshiyou-hf at loongson.cn
Sat Aug 25 06:03:54 EEST 2018


>> Hi Michael, please help to review the following updates.
>>
>>
>> diff --git a/configure b/configure
>> index b9c9d0b..08cf48e 100755
>> --- a/configure
>> +++ b/configure
>> @@ -4796,15 +4796,24 @@ elif enabled mips; then
>>                  disable mipsfpu
>>                  disable mipsdsp
>>                  disable mipsdspr2
>> +                # When gcc version less than 5.3.0, add -fno-expensive-optimizations flag.
>> +                if [ $cc == gcc ]; then
>> +                    gcc_version=$(gcc -dumpversion)
>> +                    if [ "$(echo "$gcc_version 5.3.0" | tr " " "\n" |
>> + sort -rV | head -n 1)" ==
>> "$gcc_version" ]; then
>> +                        expensive_optimization_flag=""
>> +                    else
>> +                        expensive_optimization_flag="-fno-expensive-optimizations"
>> +                    fi
>> +                fi
>
>This patch looks corrupted (by a newline)
>
>[...]


Hi Michael, has repasted below, To avoid being corrupted again, I add an attachment.

diff --git a/configure b/configure
index b9c9d0b..08cf48e 100755
--- a/configure
+++ b/configure
@@ -4796,15 +4796,24 @@ elif enabled mips; then
                 disable mipsfpu
                 disable mipsdsp
                 disable mipsdspr2
+                # When gcc version less than 5.3.0, add -fno-expensive-optimizations flag.
+                if [ $cc == gcc ]; then
+                    gcc_version=$(gcc -dumpversion)
+                    if [ "$(echo "$gcc_version 5.3.0" | tr " " "\n" | sort -rV | head -n 1)"
=="$gcc_version" ]; then
+                        expensive_optimization_flag=""
+                    else
+                        expensive_optimization_flag="-fno-expensive-optimizations"
+                    fi
+                fi
                 case $cpu in
                     loongson3*)
-                        cpuflags="-march=loongson3a -mhard-float -fno-expensive-optimizations"
+                        cpuflags="-march=loongson3a -mhard-float $expensive_optimization_flag"
                     ;;
                     loongson2e)
-                        cpuflags="-march=loongson2e -mhard-float -fno-expensive-optimizations"
+                        cpuflags="-march=loongson2e -mhard-float $expensive_optimization_flag"
                     ;;
                     loongson2f)
-                        cpuflags="-march=loongson2f -mhard-float -fno-expensive-optimizations"
+                        cpuflags="-march=loongson2f -mhard-float $expensive_optimization_flag"
                     ;;
                 esac
             ;;
--
2.1.0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-configure-loongson-revert-no-expensive-optimizations.patch
Type: application/octet-stream
Size: 2216 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180825/1afab884/attachment.obj>


More information about the ffmpeg-devel mailing list