[FFmpeg-devel] [PATCH V2] examples/vaapi_dec_scaling: add a vaapi decoding/scaling sample

[Mark Thompson]

On 23/08/18 14:08, Jun Zhao wrote:
> add a vaapi decoding/scaling sample.
> 
> Signed-off-by: Jun Zhao <mypopydev at gmail.com>
> ---
>  configure                        |    2 +
>  doc/examples/Makefile            |    1 +
>  doc/examples/vaapi_dec_scaling.c |  377 ++++++++++++++++++++++++++++++++++++++
>  3 files changed, 380 insertions(+), 0 deletions(-)
>  create mode 100644 doc/examples/vaapi_dec_scaling.c

Looking at this, it seems like it copies a lot of code from hw_decode.c and filtering_video.c and combines it in a reasonably straightforward (?) way, but doesn't really any anything on top of that.  I'm not convinced that adding an extra example like this for a specific combination of things already covered is necessarily helpful, though I could certainly be convinced if you have some reason for it.

So, would you care to argue for why this example in particular is useful?

Thanks,

- Mark