[FFmpeg-devel] [PATCH 4/4] avformat/concatdec: always re-calculate start time and duration

Nicolas George george at nsup.org
Thu Dec 13 20:35:49 EET 2018

Marton Balint (2018-12-09):
> Seeking will only work in the special case I provided in the commit message,
> when we always seek back to the beginning and otherwise read the referenced
> files continously.
> In theory, when we are in "seekable" state then if we detect a duration
> change we could indeed update all subsequent start times to provide proper
> timestamps for seeking, but I did not need this for my purpose, and I am not
> sure if it's worth the extra code needed.

I am really not comfortable with leaving the loaded gun of the seekable
flag if it does not work reliably. I think at the very least the code
should detect a file change, emit a warning and invalidate all
subsequent durations.

Note that if all you are interested in is seeking to the beginning of
the virtual file, it can always work. I would not object to a special
case in the seek code for that.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181213/0a8d6bc8/attachment.sig>

More information about the ffmpeg-devel mailing list