[FFmpeg-devel] [PATCH] avformat/nutenc: Document trailer index assert better

Michael Niedermayer michael at niedermayer.cc
Sun Dec 16 11:16:03 EET 2018


On Fri, Dec 14, 2018 at 09:59:25PM +0100, Paul B Mahol wrote:
> On 12/14/18, Michael Niedermayer <michael at niedermayer.cc> wrote:
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavformat/nutenc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/nutenc.c b/libavformat/nutenc.c
> > index a92ff55c01..e9a3bb49db 100644
> > --- a/libavformat/nutenc.c
> > +++ b/libavformat/nutenc.c
> > @@ -1172,7 +1172,7 @@ static int nut_write_trailer(AVFormatContext *s)
> >
> >      ret = avio_open_dyn_buf(&dyn_bc);
> >      if (ret >= 0 && nut->sp_count) {
> > -        av_assert1(nut->write_index);
> > +        av_assert1(nut->write_index); // sp_count should be 0 if no index
> > is going to be written
> >          write_index(nut, dyn_bc);
> >          put_packet(nut, bc, dyn_bc, 1, INDEX_STARTCODE);
> >      }
> > --
> > 2.19.2
> 
> Yea, figured it later, patch is fine.

will apply

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181216/c959a388/attachment.sig>


More information about the ffmpeg-devel mailing list