[FFmpeg-devel] [PATCH] Fix usage of temp_file flag in hls_flags option

[Adrian]

Yeah, it does. My device is running as we speak and I do see tmp files being created and renamed once done.

Regards
Adrian Guzowski17 gru 2018 16:19 Steven Liu <lq at chinaffmpeg.org> napisał(a):
>
> > On Dec 17, 2018, at 23:11, Adrian <adrian-007 at o2.pl> wrote:
> > 
> > Looks like it, though I've fixed some inconsistencies in file checking too (i.e you're renaming file A, but checks file B for being able to be temp file) + added checking flag for HLS_SINGLE_FILE (it doesn't make sense to have HLS_TEMP_FILE | HLS_SINGLE_FILE).
> > 
> > My bad I didn't check pending patches - sorry!
> > 
> Dose that patch can fix the problem? I will push it if that can fix. :-)
> > Regards
> > Adrian Guzowski
> > 
> > W dniu 17.12.2018 o 16:00, Steven Liu pisze:
> >> 
> >>> On Dec 17, 2018, at 22:23, Adrian <adrian-007 at o2.pl> wrote:
> >>> 
> >>> Hello,
> >>> 
> >>> after upgrading FFmpeg from 4.0 to 4.1 I noticed that temp files in HLS muxed stopped working.
> >>> It looks like a regression introduced by 223d2bde22ce33dcbcb6f17f234b609cb98f1fb6. I've prepared a patch and tested it cross-compiling for my project's target platform (ARM, Buildroot) and it seems like everything is in order. I ran regression tests and nothing seems to be broken.
> >>> 
> >>> Please review it and possibly include this patch.
> >> https://patchwork.ffmpeg.org/patch/11410/
> >> 
> >> Dose this patch same as your patch?
> >>> Regards
> >>> Adrian Guzowski
> >>> 
> >>> <0001-Fix-usage-of-temp_file-flag-in-hls_flags-option.patch>_______________________________________________
> >>> ffmpeg-devel mailing list
> >>> ffmpeg-devel at ffmpeg.org
> >>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >> Thanks
> >> Steven
> >> 
> >> 
> >> 
> >> _______________________________________________
> >> ffmpeg-devel mailing list
> >> ffmpeg-devel at ffmpeg.org
> >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> Thanks
> Steven
>
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel