[FFmpeg-devel] [PATCH] Fix usage of temp_file flag in hls_flags option

Aleksey Skripka caspy at undev.ru
Mon Dec 17 17:36:15 EET 2018


with your variant of patch in case of '-hls_flags +temp_file+single_file' no .tmp logic will be used.
not sure what is better, but all previous versions was doing so.

and also, i'm still sure, that for backward compatibility with all previous versions, index.m3u8 should always be written via .tmp file.

i noticed this bug such way: i do not use +temp_file, but rely on atomic rename of index.m3u8.

> On 17 Dec 2018, at 17:23, Adrian <adrian-007 at o2.pl> wrote:
> Hello,
> after upgrading FFmpeg from 4.0 to 4.1 I noticed that temp files in HLS muxed stopped working.
> It looks like a regression introduced by 223d2bde22ce33dcbcb6f17f234b609cb98f1fb6. I've prepared a patch and tested it cross-compiling for my project's target platform (ARM, Buildroot) and it seems like everything is in order. I ran regression tests and nothing seems to be broken.
> Please review it and possibly include this patch.
> Regards
> Adrian Guzowski
> <0001-Fix-usage-of-temp_file-flag-in-hls_flags-option.patch>_______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Aleksey Skripka

More information about the ffmpeg-devel mailing list