[FFmpeg-devel] [PATCH V5 0/2] Add libsvt HEVC encoder wrapper
Carl Eugen Hoyos
ceffmpeg at gmail.com
Sat Dec 22 14:02:59 EET 2018
2018-12-22 10:15 GMT+01:00, Jun Zhao <mypopydev at gmail.com>:
> The Scalable Video Technology for HEVC Encoder (SVT-HEVC Encoder) is an
> HEVC-compliant encoder library core that achieves excellent density-quality
I don't find it ideal that FFmpeg git claims that an Intel encoder
does something "excellent" - unrelated to our actual opinion.
> tradeoffs, and is highly optimized for Intel Xeon Scalable Processor and
(and while there, also remove / change "highly optimized")
> Xeon D processors. Intel open source SVT-HEVC encoder in:
> This wrapper work with SVT-HEVC master branch, more information can get
> from https://github.com/intel/SVT-HEVC/blob/new_api/ffmpeg_plugin/.
This is irrelevant:
If SVT is another example of a library that does not plan some kind
of api stability, we should not merge your patch.
If api stability is to be expected, the sentence is not necessary.
> For SVT-HEVC build, you can switch the branch to master, then run:
This should not be part of the commit message here.
Add some quality metrics in the email.
Explain that the license (and the fact that the encoder is not terrible)
is sufficient reason to merge.
More information about the ffmpeg-devel