[FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

Michael Niedermayer michael at niedermayer.cc
Sun Dec 23 13:08:09 EET 2018

On Sat, Dec 22, 2018 at 09:28:47PM +0100, Steinar H. Gunderson wrote:
> On Sat, Dec 22, 2018 at 09:18:11PM +0100, Paul B Mahol wrote:
> > Unacceptable, I'm not adding another yuv420p variant.
> Well, if returning YCC as YCC is unacceptable, and converting YCC to RGB is
> unacceptable, I believe your only choices are:
>   1. Try to convert YCC to Y'CbCr ignoring the gamma curve, which will return
>      images that look wrong and cannot be repaired by reasonable means.
>   2. Return YCC mislabeled as something else, which will look even more wrong.
>   3. Don't include PhotoCD support in FFmpeg.

a user switch could be added to choose between RGB and incorrect YCbCr
the alternative would be adding support to swscale for the new variant
and some means to transport the information to it so its converted
correctly. for example by using AVColor* enums

I think doing this in swscale is the "proper" solution but doing it in
the decoder is not that unreasonable as this is a rather odd format.
Also another pixfmt is not ideal as paul already mentioned. Though i
would not outright reject that option, its probably easier to do than
using AVColor* enums and have this all working well

either way, iam fine with whatever others are fine with ...


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181223/7ecd5726/attachment.sig>

More information about the ffmpeg-devel mailing list