[FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

Carl Eugen Hoyos ceffmpeg at gmail.com
Fri Dec 28 01:08:36 EET 2018


2018-12-27 22:02 GMT+01:00, Uwe Freese <uwe.freese at gmx.de>:

> Am 27.12.18 um 20:25 schrieb Carl Eugen Hoyos:
>>
>>> I have now added as error handling:
>>>
>>> av_log(inlink->src, AV_LOG_ERROR, "More planes in frame than
>>> expected.\n");
>>> return AVERROR(ENOMEM);
>>>
>>> Is this ok, or how should this be implemented instead?
>>
>> Not sure I understand: How can plane get >= MAX_PLANES?
>> If this is impossible (as I believe), please use av_assert0().
>
> I meant the use of "ENOMEM" and if there's a better error
> constant to use here.
>
> At this line, the error is not about memory, but that the video input
> format is unexpected.

Is there a format with too many planes?
If not, please use an assert, do not return an error.

Carl Eugen


More information about the ffmpeg-devel mailing list