[FFmpeg-devel] [PATCH] libavfilter: constify filter list

Nicolas George george at nsup.org
Thu Feb 1 12:03:33 EET 2018


Muhammad Faiz (2018-01-30):
> Move REGISTER_FILTER to FILTER_TABLE in configure.
> Auto generate filter extern and filter table.
> Sort filter table, use bsearch on avfilter_get_by_name.
> Define next pointer at filter extern, no need to initialize
> next pointer at run time, so AVFilter can be set to const.
> Make avfilter_register always return error.
> Target checkasm now depends on EXTRALIBS-avformat.

Regarding registering user filters, do not bother about that. That ship
has sailed a long time ago; it is already more than half-way across and
decelerating. If somebody wants to implement plugins, they will have a
lot of work. Designing a way of registering user filters so that they
can be parsed by name would be a spoonful in the pool.

Regarding the actual implementation:

I do not like that you moved the list into configure. Not per se, but
because it is completely different from what Josh de Kock is doing with
codecs, parsers and formats. Please coordinate with Josh to have a
consistent solution for all components.

I think the fact that you need to insert a line in each filter is rather
a sign that the design is far from perfect.

Regarding the efficiency of avfilter_next(), I think we should not care.
Almost nobody uses that function outside lavfi anyway. If it proves a
concern for some application, we can deal with it when it is found.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180201/9ca35a16/attachment.sig>

More information about the ffmpeg-devel mailing list