[FFmpeg-devel] avformat/utils : estimate_timings_from_pts - increase retrys

[Michael Niedermayer]

On Mon, Feb 05, 2018 at 05:52:25PM +0000, Gaullier Nicolas wrote:
> The number of extra retries to get more than a single duration is currently limited to 1 (see commit 77a0df4b5).
> This patch raises this number of retries to 4 (amongst the overall 6 max retries).
> In my experience, the need for 2 extra retries is something commonplace.
> 3 extra retries is not far away and we have an exemple on ffmpeg.org :
> http://samples.ffmpeg.org/archive/extension/ts/mpegts+mpeg2video+ac3++mpegts_multiple_ts_packets_pmt_pid_0x50.ts
> 
> I have encountered at least one time a file (SPTS) that requires 4 extra retries, this is why I propose to set this value.
> 
> Thank you for your review
> Nicolas Gaullier

>  utils.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> f28d63e7efcfc9dae66a90d2a3bd32b65f983bd4  0001-avformat-utils-estimate_timings_from_pts-increase-re.patch
> From a11e24cc03932264eeb3ea09007cc253e0aa9968 Mon Sep 17 00:00:00 2001
> From: Nicolas Gaullier <nicolas.gaullier at arkena.com>
> Date: Mon, 5 Feb 2018 18:14:27 +0100
> Subject: [PATCH] avformat/utils : estimate_timings_from_pts - increase retrys
>  if missing some a/v durations

This would make the code read much more of the file if it cannotz figure
out the duration of every stream.

In which use case are the individual stream durations needed ?

btw, while 4 retries might sound low, each reads twice as much data
than the previous IIRC

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Take away the freedom of one citizen and you will be jailed, take away
the freedom of all citizens and you will be congratulated by your peers
in Parliament.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180206/d634689f/attachment.sig>