[FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

[wm4]

On Fri, 9 Feb 2018 03:08:26 +0100
Michael Niedermayer <michael at niedermayer.cc> wrote:

> On Tue, Jan 30, 2018 at 04:11:03PM -0500, Nablet Developer wrote:
> > protocol requires libsrt (https://github.com/Haivision/srt) to be
> > installed
> > 
> > Signed-off-by: Nablet Developer <sdk at nablet.com>
> > ---
> >  MAINTAINERS             |   1 +
> >  configure               |   9 +
> >  doc/protocols.texi      | 116 +++++++++
> >  libavformat/Makefile    |   1 +
> >  libavformat/opensrt.c   | 621 ++++++++++++++++++++++++++++++++++++++++++++++++
> >  libavformat/protocols.c |   1 +
> >  6 files changed, 749 insertions(+)
> >  create mode 100644 libavformat/opensrt.c
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index ba7a728..0317f24 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -498,6 +498,7 @@ Protocols:
> >    http.c                                Ronald S. Bultje
> >    libssh.c                              Lukasz Marek
> >    mms*.c                                Ronald S. Bultje
> > +  opensrt.c                             Nablet Developer
> >    udp.c                                 Luca Abeni
> >    icecast.c                             Marvin Scholz  
> 
> Is "Nablet Developer" identifying a single person ?
> if not this is not ok as the MAINTAINERS files gives one also the right to
> have git write access and that would not work with a unspecified group

I'd assume this is under the copyright of that nablet company. I'd
advise against just giving some drive-by contributor git push
access (who is probably multiple persons under a single account too). I
have no idea why you'd even consider that.

Also, the irony of the situation is that the whole diff context in this
patch consists of outdated entries. Ronald basically doesn't care
about HTTP or MMS anymore, Lukasz didn't post here for 2 years, Luca
didn't post here for at least 5 years, and refused my mpv relicensing
request because he has utterly negative memories of ffmpeg & co, and
Marvin didn't post here for about 4 years.