[FFmpeg-devel] [PATCH 2/2] libavfilter/vf_fps: Rewrite using activate callback

Tobias Rapp t.rapp at noa-archive.com
Mon Feb 19 14:20:57 EET 2018


On 16.02.2018 21:09, calvin.walton at kepstin.ca wrote:
> Oops, I forgot to remove this bit from the changelog:
> 
> On Fri, 2018-02-16 at 15:02 -0500, Calvin Walton wrote:
>> TODO: This is still a work in progress. It may have different
>> behaviour
>> in some cases from the old fps filter. I have not yet implemented the
>> "eof_action" option, since I haven't figured out what it's supposed
>> to
>> do.
> 
> At this point I'm fairly confident that the behaviour matches the
> existing filter, and that I've gotten the eof_action behaviour correct
> as well.

I have run this patch against some private test files with filter 
options "fps=1:round=near:eof_action=pass" and found no regressions. So 
eof_action seems to work fine, indeed.

Regards,
Tobias



More information about the ffmpeg-devel mailing list