[FFmpeg-devel] [PATCH v3 0/2] libavfilter/vf_fps: Rewrite using activate callback

Calvin Walton calvin.walton at kepstin.ca
Thu Feb 22 21:10:02 EET 2018

This revision of the patch fixes statistics by counting the number of
times each frame has been output, rather than trying to guess at the
time each frame is output whether it was a duplicate or drop.

I ended up leaving the conditional check
    if (s->status && s->frames_count == 0) {
at the bottom of the activate function. I think I agree that the
condition will always be true, based on the code flow, but the if
statement documents the condition just as well as an assert would, and
it's not like the EOF handling is in a hot path where we'd want to
compile out the check.

Calvin Walton (2):
  libavfilter/vf_fps: Rewrite using activate callback
  libavfilter/vf_fps: Minor cleanups

 libavfilter/vf_fps.c | 392 ++++++++++++++++++++++++++-------------------------
 1 file changed, 202 insertions(+), 190 deletions(-)


More information about the ffmpeg-devel mailing list