[FFmpeg-devel] [PATCH 2/3] avformat/dashenc: opening a segment file when its first frame is ready

[James Almer]

On 2/24/2018 12:19 PM, Marton Balint wrote:
> 
> 
> On Mon, 19 Feb 2018, vdixit at akamai.com wrote:
> 
>> From: Vishwanath Dixit <vdixit at akamai.com>
>>
>> ---
>> libavformat/dashenc.c | 57
>> ++++++++++++++++++++++++++++++++-------------------
>> 1 file changed, 36 insertions(+), 21 deletions(-)
>>
>> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
>> index 0f6f4f2..0eb4b25 100644
>> --- a/libavformat/dashenc.c
>> +++ b/libavformat/dashenc.c
>> @@ -81,6 +81,9 @@ typedef struct OutputStream {
>>     char bandwidth_str[64];
>>
>>     char codec_str[100];
>> +    char filename[1024];
>> +    char full_path[1024];
>> +    char temp_path[1024];
>> } OutputStream;
> 
> I know it's late, but in the future please work toward supporting
> unlimited path lengths, that was the whole point of the deprecation of
> AVFormatContext->filename.
> 
> Thanks,
> Marton

It's not late, it can and should be changed. New code using deprecated
APIs that will require changes in the long run should have not been
added, so better change it now.