[FFmpeg-devel] [PATCH 4/6] lavf: move fifo test muxer into separate file

[wm4]

On Wed, 3 Jan 2018 16:46:14 +0100
Hendrik Leppkes <h.leppkes at gmail.com> wrote:

> On Wed, Jan 3, 2018 at 4:37 PM, wm4 <nfxjfg at googlemail.com> wrote:
> > On Wed, 3 Jan 2018 00:43:02 +0000
> > Josh de Kock <josh at itanimul.li> wrote:
> >  
> >> This fixes the fate-fifo-muxer test.
> >> ---
> >>  libavformat/Makefile           |   2 +-
> >>  libavformat/allformats.c       |   1 +
> >>  libavformat/fifo_test.c        | 150 +++++++++++++++++++++++++++++++++++++++++
> >>  libavformat/tests/fifo_muxer.c | 115 +------------------------------
> >>  4 files changed, 154 insertions(+), 114 deletions(-)
> >>  create mode 100644 libavformat/fifo_test.c
> >>  
> >
> > So this adds the FIFO test muxer as a standard libavformat muxer.
> > Before this, it was registered as additional filter, which is now not
> > possible anymore. I guess this is OK, unless someone can think of a
> > better way.  
> 
> We intentionally moved all test code out of the main code base, and
> not only does this move it back, its also now included in every public
> build?
> That seems hardly ideal.

I sort of agree, but how would you solve it?