[FFmpeg-devel] [PATCH] avfilter/vf_overlay: add comment into eval_expr

Steven Liu lq at chinaffmpeg.org
Tue Jan 9 04:41:44 EET 2018


comment about the looks like a duplicate line.
but that is used to reason x is expressed from y

Signed-off-by: Steven Liu <lq at chinaffmpeg.org>
---
 libavfilter/vf_overlay.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavfilter/vf_overlay.c b/libavfilter/vf_overlay.c
index aa5835ae3a..c6a6ac82f3 100644
--- a/libavfilter/vf_overlay.c
+++ b/libavfilter/vf_overlay.c
@@ -149,6 +149,7 @@ static void eval_expr(AVFilterContext *ctx)
 
     s->var_values[VAR_X] = av_expr_eval(s->x_pexpr, s->var_values, NULL);
     s->var_values[VAR_Y] = av_expr_eval(s->y_pexpr, s->var_values, NULL);
+    /* It is necessary if x is expressed from y  */
     s->var_values[VAR_X] = av_expr_eval(s->x_pexpr, s->var_values, NULL);
     s->x = normalize_xy(s->var_values[VAR_X], s->hsub);
     s->y = normalize_xy(s->var_values[VAR_Y], s->vsub);
-- 
2.14.3 (Apple Git-98)





More information about the ffmpeg-devel mailing list