[FFmpeg-devel] [PATCH 3/3] avformat/mov: Expose encryption info to the app.

Jacob Trimble modmaker at google.com
Tue Jan 9 20:28:41 EET 2018


On Mon, Jan 8, 2018 at 5:23 PM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> 2018-01-09 0:22 GMT+01:00 Jacob Trimble <modmaker-at-google.com at ffmpeg.org>:
>
>> Updated with the new design for the side data and applied the realloc
>> fix to avoid large allocations.
>
>> +        kid_count = avio_rb32(pb);
>
> Missing check here ...
>
>> +        for (; i < kid_count && !pb->eof_reached; i++) {
>> +            unsigned int min_kid_count = FFMIN(FFMAX(i, 1024), kid_count);
>> +            key_ids = av_fast_realloc(info->key_ids, &alloc_size,
>
>> +                                      min_kid_count * sizeof(*key_ids));
>
> ... for an overflow here.

Done

>
> Thank you, Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-avformat-mov-Expose-encryption-info-v3.patch
Type: text/x-patch
Size: 4783 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180109/db07fb9d/attachment.bin>


More information about the ffmpeg-devel mailing list