[FFmpeg-devel] [PATCH 1/2] lavf/http.c: Free allocated client URLContext in case of error.

Stephan Holljes klaxa1337 at googlemail.com
Wed Jan 10 04:55:20 EET 2018


On Sat, May 20, 2017 at 2:50 AM, Stephan Holljes
<klaxa1337 at googlemail.com> wrote:
> On Sat, Apr 22, 2017 at 3:18 AM, Stephan Holljes
> <klaxa1337 at googlemail.com> wrote:
>> On Tue, Apr 11, 2017 at 8:05 PM, Stephan Holljes
>> <klaxa1337 at googlemail.com> wrote:
>>> ---
>>>
>>> This version returns 0 in case of success and does not fallthrough to fail:.
>>>
>>>  libavformat/http.c | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/libavformat/http.c b/libavformat/http.c
>>> index 293a8a7..2917b6e 100644
>>> --- a/libavformat/http.c
>>> +++ b/libavformat/http.c
>>> @@ -535,7 +535,11 @@ static int http_accept(URLContext *s, URLContext **c)
>>>          goto fail;
>>>      cc->hd = cl;
>>>      cc->is_multi_client = 1;
>>> +    return 0;
>>>  fail:
>>> +    if (c) {
>>> +        ffurl_close(*c);
>>> +    }
>>>      return ret;
>>>  }
>>>
>>> --
>>> 2.9.3
>>>
>>
>> Friendly ping :)
>
> Ping.

These patches still seem to apply, ping :)


More information about the ffmpeg-devel mailing list