[FFmpeg-devel] [PATCH v3 2/4] avformat/libopenmpt: Update to libopenmpt 0.3 API

Michael Niedermayer michael at niedermayer.cc
Fri Jan 12 13:36:40 EET 2018


On Thu, Jan 11, 2018 at 09:11:30AM +0100, Jörn Heusipp wrote:
> libopenmpt 0.3 deprecates openmpt_module_create_from_memory() and
> provides a replacement function openmpt_module_create_from_memory2().
> 
> Detecting libopenmpt 0.3 can be done at build time via the API
> version macros provided by libopenmpt. libopenmpt 0.2 did not provide
> all required macros, however libopenmpt documents the required #define
> shims that can be safely added for libopenmpt 0.2.
> 
> Using openmpt_module_create_from_memory2() instead of
> openmpt_module_create_from_memory() avoids the deprecation warning
> when building ffmpeg with libopenmpt 0.3.
> 
> openmpt_module_create_from_memory2() provides more fine-grained error
> reporting and in particular allows distinguishing out-of-memory from
> input file parsing errors. Return appropriate ffmpeg errors
> accordingly.
> 
> libopenmpt 0.3 is ABI and API compatible with applications built
> against libopenmpt 0.2. Building ffmpeg with libopenmpt 0.2 is still
> supported.
> 
> Signed-off-by: Jörn Heusipp <osmanx at problemloesungsmaschine.de>
> ---
>  libavformat/libopenmpt.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)

applied

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

You can kill me, but you cannot change the truth.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180112/5c70fc03/attachment.sig>


More information about the ffmpeg-devel mailing list