[FFmpeg-devel] [PATCH] libavfilter: constify filter list

Muhammad Faiz mfcc64 at gmail.com
Tue Jan 30 15:16:50 EET 2018


On Tue, Jan 30, 2018 at 2:58 PM, wm4 <nfxjfg at googlemail.com> wrote:
> On Tue, 30 Jan 2018 14:24:12 +0700
> Muhammad Faiz <mfcc64 at gmail.com> wrote:
>
>> Move REGISTER_FILTER to FILTER_TABLE in configure.
>> Auto generate filter extern and filter table.
>> Sort filter table, use bsearch on avfilter_get_by_name.
>> Define next pointer at filter extern, no need to initialize
>> next pointer at run time, so AVFilter can be set to const.
>> Make avfilter_register always return error.
>> Target checkasm now depends on EXTRALIBS-avformat.
>>
>> Signed-off-by: Muhammad Faiz <mfcc64 at gmail.com>
>> ---
>
> Pretty nice. Should we still add a new filter listing API that uses the
> same idiom as the BSF API? (Although you generate the .next links at
> configure time it might still be nice to eventually get rid of that.)

IMHO, it is uglier (i.e. by requiring opaque pointer). I don't know
other people's opinion. Anyway, it can be added later.


More information about the ffmpeg-devel mailing list