[FFmpeg-devel] [PATCH] Avoid undefined behavior by limiting PTS to 62 bits in ogg decoder

Michael Niedermayer michael at niedermayer.cc
Wed Jul 18 14:03:51 EEST 2018


On Mon, Jul 16, 2018 at 04:32:14PM -0700, Fredrik Hubinette wrote:
> With some (garbled) OGG data, PTS can overflow causing undefined behavior.
> This patch avoids that by zeroing out PTS values greater than 2^62.

>  oggdec.h |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> ff003b78842c7724ccc1a42f9584b1f8aa0b0b3d  0001-Avoid-undefined-behavior-by-limiting-PTS-to-62-bits-.patch
> From 26a8582bc04f5bddc037ffcce99025e2f977abe0 Mon Sep 17 00:00:00 2001
> From: Fredrik Hubinette <hubbe at google.com>
> Date: Mon, 16 Jul 2018 14:54:43 -0700
> Subject: [PATCH] Avoid undefined behavior by limiting PTS to 62 bits in ogg
>  decoder
> 
> ---
>  libavformat/oggdec.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

I think someone reading this commit message would like to know more
about where that undefined behaviour occurs and how this is guranteeing
to fix it


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

"Nothing to hide" only works if the folks in power share the values of
you and everyone you know entirely and always will -- Tom Scott

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180718/c8c385bb/attachment.sig>


More information about the ffmpeg-devel mailing list