[FFmpeg-devel] [PATCH] avcodec: parse options from AVCodec.bsfs

[Carl Eugen Hoyos]

2018-07-19 21:47 GMT+02:00, James Almer <jamrial at gmail.com>:
> On 7/19/2018 4:31 PM, Nicolas George wrote:
>> James Almer (2018-07-19):
>>> This is more in line with the similar error above. Aborting gracefully
>>> by printing a message and returning an error value instead of a hard
>>> abort() with no explanation as to why "ret == AVERROR(ENOMEM)" was
>>> expected.
>>
>> Explaining to whom? If it is a consistency bug within lavc, notifying
>> the user is worthless, the correct thing to do is to prevent the
>> inconsistency from getting committed, hence assert and FATE test.
>>
>> Regards,
>
> AVOptions available in bitstream filters, or even the range of accepted
> values, may depend on configure time options (external or internal
> dependencies). A simple ./configure could enable all that's needed for
> the option to be available as required by the decoder auto inserting the
> bsf, but ./configure --disable-everything --enable-decoder=foo may not.

Then I believe BUG is not the correct error value as users are allowed
not to enable all features.

Carl Eugen