[FFmpeg-devel] [PATCH] fate: qt-faststart target doesn't include PROGSSUF

Gyan Doshi gyandoshi at gmail.com
Fri Jun 15 20:14:57 EEST 2018


The recently added qt-faststart references the tool using $(PROGSSUF).

However, that tool isn't built with the suffix when supplied, and so the 
test fails for me. Patch fixes it.
-------------- next part --------------
From df8ac19a005524bc152c9fae53b4dddc29dc9257 Mon Sep 17 00:00:00 2001
From: Gyan Doshi <ffmpeg at gyani.pro>
Date: Fri, 15 Jun 2018 22:38:26 +0530
Subject: [PATCH] fate: qt-faststart target doesn't include PROGSSUF

Fixes qt-faststart test for when PROGSSUF is supplied.
---
 tests/Makefile     | 2 +-
 tests/fate/mov.mak | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/Makefile b/tests/Makefile
index 409d88a9f1..e564279b0a 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -194,7 +194,7 @@ $(FATE_FFMPEG) $(FATE_SAMPLES_AVCONV) $(FATE_SAMPLES_FFMPEG): ffmpeg$(PROGSSUF)$
 
 $(FATE_FFPROBE) $(FATE_SAMPLES_FFPROBE): ffprobe$(PROGSSUF)$(EXESUF)
 
-$(FATE_SAMPLES_FASTSTART): tools/qt-faststart$(PROGSSUF)$(EXESUF)
+$(FATE_SAMPLES_FASTSTART): tools/qt-faststart$(EXESUF)
 
 ifdef SAMPLES
 FATE += $(FATE_FULL) $(FATE_FULL-yes)
diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak
index b9c1ad9d3a..6f0e28d21e 100644
--- a/tests/fate/mov.mak
+++ b/tests/fate/mov.mak
@@ -113,6 +113,6 @@ fate-mov-guess-delay-1: CMD = run ffprobe$(PROGSSUF)$(EXESUF) -show_entries stre
 fate-mov-guess-delay-2: CMD = run ffprobe$(PROGSSUF)$(EXESUF) -show_entries stream=has_b_frames -select_streams v $(TARGET_SAMPLES)/h264/h264_3bf_pyramid_nobsrestriction.mp4
 fate-mov-guess-delay-3: CMD = run ffprobe$(PROGSSUF)$(EXESUF) -show_entries stream=has_b_frames -select_streams v $(TARGET_SAMPLES)/h264/h264_4bf_pyramid_nobsrestriction.mp4
 
-fate-mov-faststart-4gb-overflow: CMD = run tools/qt-faststart$(PROGSSUF)$(EXESUF) $(TARGET_SAMPLES)/mov/faststart-4gb-overflow.mov faststart-4gb-overflow-output.mov > /dev/null ; md5sum faststart-4gb-overflow-output.mov | cut -d " " -f1 ; rm faststart-4gb-overflow-output.mov
+fate-mov-faststart-4gb-overflow: CMD = run tools/qt-faststart$(EXESUF) $(TARGET_SAMPLES)/mov/faststart-4gb-overflow.mov faststart-4gb-overflow-output.mov > /dev/null ; md5sum faststart-4gb-overflow-output.mov | cut -d " " -f1 ; rm faststart-4gb-overflow-output.mov
 fate-mov-faststart-4gb-overflow: CMP = oneline
 fate-mov-faststart-4gb-overflow: REF = bc875921f151871e787c4b4023269b29
-- 
2.12.2.windows.2


More information about the ffmpeg-devel mailing list