[FFmpeg-devel] [PATCH 1/1] Add null check for the frame pointer

Nicolas George george at nsup.org
Mon Jun 25 11:34:37 EEST 2018


Baozeng (2018-06-25):
> The argument `frame` for avcodec_receive_frame function is user
> controlled. If a null pointer is passed from the user, it will cause a
> segmentation fault.

Nack. Passing NULL there is a bug by the user, it needs to be fixed by
the user. This patch would make it harder to detect. An assert would be
acceptable.

Also, please check how you sent this mail, it ended up in a non-standard
format. And remember to add a context in git commit messages.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180625/554c7cc1/attachment.sig>


More information about the ffmpeg-devel mailing list