[FFmpeg-devel] [PATCH] avutil/encryption_info: Fix documentation problem.

[Carl Eugen Hoyos]

2018-06-26 18:32 GMT+02:00, Jacob Trimble <modmaker-at-google.com at ffmpeg.org>:
> Signed-off-by: Jacob Trimble <modmaker at google.com>
> ---
>  libavutil/encryption_info.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/encryption_info.h b/libavutil/encryption_info.h
> index 9140968fde..8fe7ebfe43 100644
> --- a/libavutil/encryption_info.h
> +++ b/libavutil/encryption_info.h
> @@ -129,7 +129,7 @@ typedef struct AVEncryptionInitInfo {
>   *
>   * @param subsample_count The number of subsamples.
>   * @param key_id_size The number of bytes in the key ID, should be 16.
> - * @param key_id_size The number of bytes in the IV, should be 16.
> + * @param iv_size The number of bytes in the IV, should be 16.

Unrelated to this patch but since you work on this code:
Could you add a comment to the existing documentation
that our security function were written with performance
in mind (as makes sense for multimedia usage) but no
precautions against side-channel attacks were taken?

Thank you, Carl Eugen