[FFmpeg-devel] [PATCH 3/5] CodeAi generated fix for CWE 457 Uninitialized Variable

Nicolas George george at nsup.org
Wed Mar 7 01:37:02 EET 2018


C0deAi (2018-03-06):
> Prevent passing of uninitialized value 'buf[i]' as function
> call argument on line 222.
> 
> Signed-off-by: C0deAi <benjamin.bales at assrc.us>
> ---
>  libavutil/hash.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Nack. buf[i] cannot be unitialized at this point.

Also, the first line of commit message should be "lavu/hash: fix...".

The same comment about commit messages applies to the other patches. I
suspect some of them fix nothing too, but I do not have time to check
right now.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180307/642508e6/attachment.sig>


More information about the ffmpeg-devel mailing list