[FFmpeg-devel] [PATCH] avcodec/avpacket: remove unnecessary check in av_packet_make_writable()

James Almer jamrial at gmail.com
Tue Mar 27 17:29:00 EEST 2018


On 3/25/2018 9:25 PM, James Almer wrote:
> Zero sized packets are already handled below in the function.
> This is more in line with av_packet_ref().
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
>  libavcodec/avpacket.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c
> index 0693ca6f62..0993481961 100644
> --- a/libavcodec/avpacket.c
> +++ b/libavcodec/avpacket.c
> @@ -660,9 +660,6 @@ int av_packet_make_writable(AVPacket *pkt)
>      if (pkt->buf && av_buffer_is_writable(pkt->buf))
>          return 0;
>  
> -    if (!pkt->data)
> -        return AVERROR(EINVAL);
> -
>      ret = packet_alloc(&buf, pkt->size);
>      if (ret < 0)
>          return ret;

Applied.


More information about the ffmpeg-devel mailing list