[FFmpeg-devel] [PATCH] avfilter/vf_signature: use av_strlcpy()

Michael Niedermayer michael at niedermayer.cc
Fri Mar 30 04:30:51 EEST 2018


Fixes: out of array access

Found-by: Kira <kira_cxy at foxmail.com>
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavfilter/vf_signature.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavfilter/vf_signature.c b/libavfilter/vf_signature.c
index f0078ba1a6..d07b213f31 100644
--- a/libavfilter/vf_signature.c
+++ b/libavfilter/vf_signature.c
@@ -576,7 +576,8 @@ static int export(AVFilterContext *ctx, StreamContext *sc, int input)
         /* error already handled */
         av_assert0(av_get_frame_filename(filename, sizeof(filename), sic->filename, input) == 0);
     } else {
-        strcpy(filename, sic->filename);
+        if (av_strlcpy(filename, sic->filename, sizeof(filename)) >= sizeof(filename))
+            return AVERROR(EINVAL);
     }
     if (sic->format == FORMAT_XML) {
         return xml_export(ctx, sc, filename);
-- 
2.16.2



More information about the ffmpeg-devel mailing list