[FFmpeg-devel] [PATCH 04/13] avformat/mxfenc: Add object model version

[Michael Niedermayer]

On Tue, May 08, 2018 at 12:32:17PM +0200, Tomas Härdin wrote:
> mån 2018-05-07 klockan 12:38 +0200 skrev Michael Niedermayer:
> > > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> 
> >      mxf_write_metadata_key(pb, 0x012f00);
> >      PRINT_KEY(s, "preface key", pb->buf_ptr - 16);
> > -    klv_encode_ber_length(pb, 130 + 16LL * DESCRIPTOR_COUNT(mxf->essence_container_count));
> > +    klv_encode_ber_length(pb, 138 + 16LL * DESCRIPTOR_COUNT(mxf->essence_container_count));
> >  
> >      // write preface set uid
> >      mxf_write_local_tag(pb, 16, 0x3C0A);
> > @@ -696,6 +697,10 @@ static void mxf_write_preface(AVFormatContext *s)
> >      mxf_write_local_tag(pb, 2, 0x3B05);
> >      avio_wb16(pb, 259); // v1.2
> >  
> > +    // Object Model Version
> > +    mxf_write_local_tag(pb, 4, 0x3B07);
> > +    avio_wb32(pb, 1);
> > 
> 
> Not sure what use this is, but looks OK at least. S377m doesn't seem to
> think it's necessary. Is there some program that needs this?

Other tools (XFConvert at least) writes it. I think we should too.

will document this in the commit message and apply

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180508/7a3657e0/attachment.sig>