[FFmpeg-devel] [PATCH v3] avformat/mxfenc: add h264 profiles

[Thomas Mundt]

2018-05-07 10:40 GMT+02:00 Tomas Härdin <tjoppen at acc.umu.se>:

> sön 2018-05-06 klockan 21:31 +0200 skrev Thomas Mundt:
> > 2018-05-06 13:32 GMT+02:00 Tomas Härdin <tjoppen at acc.umu.se>:
> >
> > > fre 2018-05-04 klockan 01:52 +0200 skrev Thomas Mundt:
> > > > Hi,
> > > >
> > > > this is a better version of the patch.
> > > > 10 bit and TFF are mandatory for AVC Intra only. Other profiles
> > > > differ.
> > > >
> > > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> > > > index 3bb7032..81513dc 100644
> > > > --- a/libavformat/mxfenc.c
> > > > +++ b/libavformat/mxfenc.c
> > > > @@ -1947,22 +1947,31 @@ static const struct {
> > > >      int frame_size;
> > > >      int profile;
> > > >      uint8_t interlaced;
> > > > +    int long_gop;
> > >
> > > A comment here explaining the difference between -1, 0 and 1 would
> > > be
> > > nice. The rest looks OK, but I didn't read the relevant specs to be
> > > 100% sure
> > > <http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>
> > >
> >
> > New patch attached.
>
> Looks OK


Thanks,

can you or someone else push it please.

Regards,
Thomas