[FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

[Mark Thompson]

On 14/05/18 23:30, Rostislav Pehlivanov wrote:
> On 14 May 2018 at 22:57, Mark Thompson <sw at jkqxz.net> wrote:
>> On 14/05/18 22:38, Rostislav Pehlivanov wrote:
>>> On 12 May 2018 at 20:49, Rostislav Pehlivanov <atomnuker at gmail.com>
>> wrote:
>>>> On 8 November 2017 at 21:26, Rostislav Pehlivanov <atomnuker at gmail.com>
>>>> wrote:
>>>>
>>>>> Signed-off-by: Rostislav Pehlivanov <atomnuker at gmail.com>
>>>>> ---
>>>>>  doc/developer.texi | 3 +++
>>>>>  1 file changed, 3 insertions(+)
>>>>>
>>>>> diff --git a/doc/developer.texi b/doc/developer.texi
>>>>> index a7b4f1d737..de7d887451 100644
>>>>> --- a/doc/developer.texi
>>>>> +++ b/doc/developer.texi
>>>>> @@ -132,6 +132,9 @@ designated struct initializers (@samp{struct s x =
>> @{
>>>>> .i = 17 @};});
>>>>>  @item
>>>>>  compound literals (@samp{x = (struct s) @{ 17, 23 @};}).
>>>>>
>>>>> + at item
>>>>> +for loops with variable definition (@samp{for (int i = 0; i < 8;
>> i++)});
>>>>> +
>>>>>  @item
>>>>>  Implementation defined behavior for signed integers is assumed to
>> match
>>>>> the
>>>>>  expected behavior for two's complement. Non representable values in
>>>>> integer
>>>>> --
>>>>> 2.15.0.403.gc27cc4dac6
>>>>>
>>>>>
>>>> Ping.
>>>> Apparently we don't support old msvc versions, so there's nothing
>> stopping
>>>> us from using them.
>>>>
>>>
>>> I'll apply this tomorrow unless there are any objections and will apply
>>> some patches to convert some of my code to this.
>>
>> On 08/11/17 23:05, Mark Thompson wrote:
>>> Before continuing with this patch I think you should at least:
>>> * Have some idea what platforms are affected.
>>> * Investigate whether these platforms have any significant user base
>> (maybe ask the user mailing lists, at least).
>>> * Propose a patch to configure which either removes support for them or
>> somehow disables them (e.g. it could test-compile a loop including a
>> declaration).
>>
>> Are these done?
>>
> 
> Yes, the only platforms mentioned were MSVC versions older than 2013, which
> are unsupported as of recent.

Do you have a link to this discussion?  I'm not sure I've seen it.

Where can I find the configure patch?

- Mark