[FFmpeg-devel] [PATCH][ticket #5522] lavc/cfhd: interlaced frame decoding added

Hendrik Leppkes h.leppkes at gmail.com
Wed May 23 01:21:56 EEST 2018


On Tue, May 22, 2018 at 10:35 PM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> 2018-05-22 17:40 GMT+02:00, Gagandeep Singh <deepgagan231197 at gmail.com>:
>
>> +            low    = s->plane[plane].subband[0];
>> +            high   = s->plane[plane].subband[8];
>> +            output = s->plane[plane].l_h[6];
>> +            for (i = 0; i < lowpass_width; i++) {
>> +                vert_filter(output, lowpass_width, low, lowpass_width,
>> high, highpass_stride, lowpass_height);
>> +                low++;
>> +                high++;
>> +                output++;
>> +            }
>>
>> -        low    = s->plane[plane].subband[0];
>> -        high   = s->plane[plane].subband[8];
>> -        output = s->plane[plane].l_h[6];
>> -        for (i = 0; i < lowpass_width; i++) {
>> -            vert_filter(output, lowpass_width, low, lowpass_width, high,
>> highpass_stride, lowpass_height);
>> -            low++;
>> -            high++;
>> -            output++;
>> -        }
>
> The patch will get much more readable (and easier to review)
> if you do not re-indent, instead send a second patch with the
> cosmetic changes only.
>

Except, no sane developer works like that. In fact many editors will
even indent for you automatically if you add new blocks, so splitting
this is a really annoying task to perform.
Instead, may I suggest a proper patch viewer which can ignore
whitespace changes? It makes reading patches with indent changes
trivial.

- Hendrik


More information about the ffmpeg-devel mailing list