[FFmpeg-devel] [GSOC] [PATCH] DNN module introduction and SRCNN filter update

Sergey Lavrushkin dualfal at gmail.com
Fri May 25 21:01:50 EEST 2018

> You should use the ff_ prefix for internal, non-static functions only.
> You don't need to use any prefix for internal structs.
> The AV* prefix is only for public structs, and the av_ prefix is for
> public functions.
> >
> >
> >     And you need to indent and prettify the tables a bit.
> >
> >
> > Do you mean kernels and biases in dnn_srcnn.h?
> > Their formatting represents their 4D structure a little bit and it is
> > similar to one that I used for the first srcnn filter version that was
> > successfully pushed before.
> Yes, and i suppose they were pushed like that without the reviewer
> noticing they had no indentation or vertical alignment.

Here is the patch with DNN module moved to libavfilter and
proper formatting of tables in dnn_srcnn.h.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: adds_dnn_srcnn.patch
Type: text/x-patch
Size: 372889 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180525/b07f8432/attachment.bin>

More information about the ffmpeg-devel mailing list