[FFmpeg-devel] [PATCH v2] fftools/ffmpeg: add an option to forbid the fallback to software path when hardware init fails

Fu, Linjie linjie.fu at intel.com
Fri Nov 9 11:00:42 EET 2018


> -----Original Message-----
> From: Eoff, Ullysses A
> Sent: Friday, November 9, 2018 11:34
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Cc: Fu, Linjie <linjie.fu at intel.com>
> Subject: RE: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: add an option to
> forbid the fallback to software path when hardware init fails
> 
> > -----Original Message-----
> > From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On
> Behalf Of Linjie Fu
> > Sent: Thursday, November 08, 2018 7:14 PM
> > To: ffmpeg-devel at ffmpeg.org
> > Cc: Fu, Linjie <linjie.fu at intel.com>
> > Subject: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: add an option to
> forbid the fallback to software path when hardware init fails
> >
> > Currently ff_get_format will go through all usable choices if the chosen
> > format was not supported. It will fallback to software path if the hardware
> > init fails.
> >
> > Provided an option "-fallback_forbid 1" in user-code to detect frame-
> >format and
> > hwaccel_get_buffer in get_buffer. If hardware init fails, returns an error.
> >
> 
> I'm not sure I like this option name ("-fallback_forbid").  How about "-
> disable_fallback",
> "-hwaccel_or_die", "-require_hwaccel" or "-no_sw_fallback"?  I like the last
> two the most.
> Or maybe someone has a better suggestion?

Thanks, will change the option name to "-require_hwaccel"  temporary in [v3] and add an error message.
Also will add some missing codes.

> > Signed-off-by: Linjie Fu <linjie.fu at intel.com>
> > ---
> >
> > [v2] detect hardware init failures in get_buffer and modify in user-code
> >



More information about the ffmpeg-devel mailing list