[FFmpeg-devel] [PATCH 4/4] cbs_h265: Add a lot more SEI parsing support

[James Almer]

On 10/27/2018 6:39 PM, Mark Thompson wrote:
> Supports both prefix and suffix SEI, decoding all of the common SEI
> types and some more obscure ones.  Most of this is tested by the
> existing tests in fate.

It would be neat to make the *_metadata filters not decompose unit types
it doesn't care about (based on user options). Before this patch, all
these SEI messages were simply copied as is, but after it they will be
fully parsed even in pass through mode, potentially slowing down the
process.

Of course, doing that would make the cbs tests useless. Maybe the
default behavior could be to not decompose what's not going to be
modified, and an option to enable it could be added that the test would use.

> ---
>  libavcodec/cbs_h2645.c                |  20 +-
>  libavcodec/cbs_h265.h                 | 124 +++++++
>  libavcodec/cbs_h265_syntax_template.c | 497 +++++++++++++++++++++++++-
>  libavcodec/hevc.h                     |   3 +
>  libavcodec/hevc_sei.h                 |   1 +
>  5 files changed, 625 insertions(+), 20 deletions(-)
> 

> diff --git a/libavcodec/hevc_sei.h b/libavcodec/hevc_sei.h
> index e92da25bbf..2fec00ace0 100644
> --- a/libavcodec/hevc_sei.h
> +++ b/libavcodec/hevc_sei.h
> @@ -52,6 +52,7 @@ typedef enum {
>      HEVC_SEI_TYPE_DECODED_PICTURE_HASH                 = 132,
>      HEVC_SEI_TYPE_SCALABLE_NESTING                     = 133,
>      HEVC_SEI_TYPE_REGION_REFRESH_INFO                  = 134,
> +    HEVC_SEI_TYPE_TIME_CODE                            = 136,
>      HEVC_SEI_TYPE_MASTERING_DISPLAY_INFO               = 137,
>      HEVC_SEI_TYPE_CONTENT_LIGHT_LEVEL_INFO             = 144,
>      HEVC_SEI_TYPE_ALTERNATIVE_TRANSFER_CHARACTERISTICS = 147,

Adding this one should be trivial, btw. It's a single field, and there
are real world samples out there. Support for it was added to the
decoder some time ago.

In any case, set looks good if FATE passes. Thanks.