[FFmpeg-devel] [PATCH v3 1/1] avcodec: implemented Media Foundation encoder wrapper

[Carl Eugen Hoyos]

2018-11-12 14:42 GMT+01:00, Paweł Wegner <pawel.wegner95 at gmail.com>:
> +    case AV_CODEC_ID_MSMPEG4V1:
> +    case AV_CODEC_ID_MSMPEG4V2:         return &ff_MFVideoFormat_MP42;

This looks unexpected: Is v1 encoding really still supported?

> +    case AV_CODEC_ID_MP1:               return &MFAudioFormat_MPEG;
> +    case AV_CODEC_ID_MP2:               return &MFAudioFormat_MPEG;

This looks wrong, mp1 and mp2 are not the same.

Carl Eugen