[FFmpeg-devel] [PATCH 3/3] avcodec/truemotion2: Check huffman code max bits

Michael Niedermayer michael at niedermayer.cc
Mon Nov 19 03:02:57 EET 2018


On Sun, Nov 18, 2018 at 11:29:10PM +0100, Tomas Härdin wrote:
> lör 2018-11-17 klockan 03:01 +0100 skrev Michael Niedermayer:
> > Fixes: Timeout
> > Fixes: 10984/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-6643310750859264
> > 
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/truemotion2.c | 15 ++++++++++-----
> >  1 file changed, 10 insertions(+), 5 deletions(-)
> > 
> > diff --git a/libavcodec/truemotion2.c b/libavcodec/truemotion2.c
> > index c583ff4032..5d12a70839 100644
> > --- a/libavcodec/truemotion2.c
> > +++ b/libavcodec/truemotion2.c
> > @@ -114,7 +114,7 @@ typedef struct TM2Huff {
> >  
> >  static int tm2_read_tree(TM2Context *ctx, uint32_t prefix, int length, TM2Huff *huff)
> 
> Since you seem to be changing what this function returns, a comment
> saying what it returns would be nice

will document this better

thanks 

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181119/7ccbd828/attachment.sig>


More information about the ffmpeg-devel mailing list