[FFmpeg-devel] [PATCH 3/5] configure: memalign is broken on djgpp 2.05

Michael Niedermayer michael at niedermayer.cc
Wed Nov 21 13:45:21 EET 2018


On Wed, Nov 21, 2018 at 10:28:16PM +1100, Peter Ross wrote:
> On Tue, Nov 20, 2018 at 11:26:31PM +0100, Michael Niedermayer wrote:
> > On Tue, Nov 20, 2018 at 11:24:10PM +0100, Michael Niedermayer wrote:
> > > On Wed, Nov 21, 2018 at 01:29:48AM +1100, Peter Ross wrote:
> > > > djgpp 2.05 finally provides posix-compatible memalign, but it is broken,
> > > > so use disable it if this version is detected.
> > > > 
> > > > discussion: http://www.delorie.com/archives/browse.cgi?p=djgpp/2017/12/29/16:26:58
> > > > ---
> > > >  configure | 11 +++++++++--
> > > >  1 file changed, 9 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/configure b/configure
> > > > index 6d58d30df6..5d2f57684c 100755
> > > > --- a/configure
> > > > +++ b/configure
> > > > @@ -6793,10 +6793,17 @@ check_deps $CONFIG_LIST       \
> > > >  enabled threads && ! enabled pthreads && ! enabled atomics_native && die "non pthread threading without atomics not supported, try adding --enable-pthreads or --cpu=i486 or higher if you are on x86"
> > > >  enabled avresample && warn "Building with deprecated library libavresample"
> > > >  
> > > > -if test $target_os = "haiku"; then
> > > > +case $target_os in
> > > > +haiku)
> > > >      disable memalign
> > > >      disable posix_memalign
> > > > -fi
> > > > +    ;;
> > > > +*-dos|freedos|opendos)
> > > > +    if test_cpp_condition sys/version.h "defined(__DJGPP__) && __DJGPP__ == 2 && __DJGPP_MINOR == 5"; then
> > > > +        disable memalign
> > > > +    fi
> > > 
> > > will this be fixed in the next version after 2.5 ?
> > 
> > s/2.5/2.05/
> 
> maybe. there is an attempted fix in djggp cvs, but ffmpeg is able to break that too. 

maybe we should "unconditionally" disable memalign for djgpp until its fixed,
not sure
either way iam fine with this patch too

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship: All citizens are under surveillance, all their steps and
actions recorded, for the politicians to enforce control.
Democracy: All politicians are under surveillance, all their steps and
actions recorded, for the citizens to enforce control.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181121/651c8862/attachment.sig>


More information about the ffmpeg-devel mailing list