[FFmpeg-devel] avcodec/proresaw_enc : improvment (vendor and color properties, 4444Xq)

[Kieran O Leary]

On Mon, Nov 26, 2018 at 8:06 AM Kieran O Leary <kieran.o.leary at gmail.com>
wrote:

>
>
> On Sat, 24 Nov 2018, 22:11 Martin Vignali <martin.vignali at gmail.com wrote:
>
>> Hello,
>>
>> Patch in attach add some improvments to prores aw encoder
>>
>> 012 : Add vendor option (code come from prores_ks encoder)
>> 013 : Only write color properties, if defined in rdd36 (other values are
>> "converted" to unspecified)
>> 014 : Add 4444 XQ encoding support
>>
>
> I hope to test these patches out today with 12-bit RGB DPX/FFV1 as input.
> Is the 4444 XQ encoder intended to be 10 or 12-bit?
>

So I applied these patches and it appears that ffmpeg will encode XQ as
10-bit, but it will decode as 12-bit. Is this intentional? I worry that I
might have applied the patches incorrectly.  And is it possible to add
12-bit encoding?

$ ./ffmpeg -f lavfi -i testsrc -c:v prores -profile:v 5 xq.mov

ffmpeg version N-92541-g598755603c Copyright (c) 2000-2018 the FFmpeg
developers

  built with Apple LLVM version 9.0.0 (clang-900.0.39.2)

  configuration:

  libavutil      56. 24.101 / 56. 24.101

  libavcodec     58. 40.100 / 58. 40.100

  libavformat    58. 23.100 / 58. 23.100

  libavdevice    58.  6.100 / 58.  6.100

  libavfilter     7. 46.100 /  7. 46.100

  libswscale      5.  4.100 /  5.  4.100

  libswresample   3.  4.100 /  3.  4.100

Input #0, lavfi, from 'testsrc':

  Duration: N/A, start: 0.000000, bitrate: N/A

    Stream #0:0: Video: rawvideo (RGB[24] / 0x18424752), rgb24, 320x240
[SAR 1:1 DAR 4:3], 25 tbr, 25 tbn, 25 tbc

File 'xq.mov' already exists. Overwrite ? [y/N] y

Stream mapping:

  Stream #0:0 -> #0:0 (rawvideo (native) -> prores (native))

Press [q] to stop, [?] for help

Output #0, mov, to 'xq.mov':

  Metadata:

    encoder         : Lavf58.23.100

    Stream #0:0: Video: prores (XQ) (ap4x / 0x78347061), yuv444p10le,
320x240 [SAR 1:1 DAR 4:3], q=2-31, 200 kb/s, 25 fps, 12800 tbn, 25 tbc

    Metadata:

      encoder         : Lavc58.40.100 prores

frame=14747 fps=2015 q=-0.0 Lsize=  469689kB time=00:09:49.84
bitrate=6523.3kbits/s speed=80.6x

video:469627kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB
muxing overhead: 0.013138%

Exiting normally, received signal 2.

telecine:ffmpeg administrator$ ./ffmpeg -i xq.mov

ffmpeg version N-92541-g598755603c Copyright (c) 2000-2018 the FFmpeg
developers

  built with Apple LLVM version 9.0.0 (clang-900.0.39.2)

  configuration:

  libavutil      56. 24.101 / 56. 24.101

  libavcodec     58. 40.100 / 58. 40.100

  libavformat    58. 23.100 / 58. 23.100

  libavdevice    58.  6.100 / 58.  6.100

  libavfilter     7. 46.100 /  7. 46.100

  libswscale      5.  4.100 /  5.  4.100

  libswresample   3.  4.100 /  3.  4.100

Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'xq.mov':

  Metadata:

    major_brand     : qt

    minor_version   : 512

    compatible_brands: qt

    encoder         : Lavf58.23.100

  Duration: 00:09:49.88, start: 0.000000, bitrate: 6522 kb/s

    Stream #0:0(eng): Video: prores (XQ) (ap4x / 0x78347061),
yuv444p12le(tv, progressive), 320x240, 6521 kb/s, SAR 1:1 DAR 4:3, 25 fps,
25 tbr, 12800 tbn, 12800 tbc (default)

    Metadata:

      handler_name    : VideoHandler
      encoder         : Lavc58.40.100 prores


Best,

Kieran.

>