[FFmpeg-devel] [PATCH] lavfi/atempo: fix range check if tempo is set by command

Nicolas George george at nsup.org
Wed Oct 3 18:58:56 EEST 2018


Wang Bin (2018-10-03):
> Less mistakes. For example the author forgot to change this line. This
> function is not frequently called.

The consistency must be ensured, but it must be static, not dynamic by
looking up the option.

Just use two constant macros.

> av_opt_set or avfilter_process_command already returns error if out of
> range. So no need to check it again.

And you are changing the bound. It should be checked with Pavel, but I
think this change is wrong.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181003/e06f1bd7/attachment.sig>


More information about the ffmpeg-devel mailing list