[FFmpeg-devel] [PATCH] avcodec/wmadec: fix WMA gapless playback

Michael Niedermayer michael at niedermayer.cc
Fri Oct 5 23:29:54 EEST 2018


On Fri, Oct 05, 2018 at 07:39:26PM +0200, bananaman255 at gmail.com wrote:
> From: bnnm <bananaman255 at gmail.com>
> 
> Fixes trac issue #7473.
> 
> Removes encoder delay (skip samples) and writes remaining frame samples after EOF to get correct sample count.
> 
> Output is now accurate vs players that use Microsoft's codecs (Windows Media Format Runtime).
> 
> Tested vs encode>decode WMAv2 with MS's codecs and most sample rate/bit rate/channel/mode combinations in ASF/XWMA. WMAv1 appears to use the same delay, from FFmpeg samples.
> 
> Signed-off-by: bnnm <bananaman255 at gmail.com>
> ---
>  libavcodec/wma.h    |  2 ++
>  libavcodec/wmadec.c | 34 ++++++++++++++++++++++++++++++++--
>  2 files changed, 34 insertions(+), 2 deletions(-)

This will/would require several fate tests to be updated
at least these apparently:
make: *** [fate-wmav1-encode] Error 1
make: *** [fate-wmav2-encode] Error 1
make: *** [fate-flcl1905] Error 1


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181005/f096ee8b/attachment.sig>


More information about the ffmpeg-devel mailing list