[FFmpeg-devel] [PATCH] h264_slice: Copy the value of x264_build before calling h264_slice_header_init during thread init

[James Almer]

On 10/8/2018 3:45 PM, Derek Buitenhuis wrote:
> On 08/10/2018 19:23, Carl Eugen Hoyos wrote:
>> I cannot reproduce ticket #7475 (it says "framerate num 30 den 1"
>> no matter how many threads I use, tested with up to 8), and - more
>> related to this patch - the sample from ticket #7475 reaches neither
>> line 358 nor line 400 in h264_slice.c here when running the command
>> shown in the ticket.
>>
>> $ md5sum crew_cif_timecode-2.h264
>> 43fbbb4ead1af31ed19dbb6582761d73  crew_cif_timecode-2.h264
>>
>> Do you know what I am doing wrong?
> 
> Your MD5 matches mine. 
> 
> Running on Linux (vanilla Debian unstable), using the patch from the trac entry:
>     $ ffmpeg -threads 1 -i crew_cif_timecode-2.h264 -f null -
> 
> I get this: https://pastebin.com/9TLB0ewm
> 
> And with:
>     $ ffmpeg -threads 2 -i crew_cif_timecode-2.h264 -f null -
> 
> I get this: https://pastebin.com/upaJUXUA
> 
> Any value above 1 should be enough to reproduce.
> 
> It's possible it may only present itself on Linux (if you are on Windows).

No, i can reproduce it on Windows with a mingw-w64 build. Same output as
the one you pasted, and your patch fixes it.