[FFmpeg-devel] [PATCH] avformat/dashenc: only write video streams into HLS master playlist

[Jeyapal, Karthick]

On 9/14/18 12:38 PM, Jian Yang wrote:
> Tool mediastreamvalidator reports error "Variant media_[N].m3u8 is
> missing audio group" for audio streams in HLS master playlist. As audio
> streams are already listed in audio group, skip them as variant media
> streams in master playlist.
> ---
>  libavformat/dashenc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index 87e31e25fc..45763301db 100644
> --- a/libavformat/dashenc.c
> +++ b/libavformat/dashenc.c
> @@ -911,8 +911,10 @@ static int write_manifest(AVFormatContext *s, int final)
>              OutputStream *os = &c->streams[i];
>              char *agroup = NULL;
>              int stream_bitrate = st->codecpar->bit_rate + os->muxer_overhead;
> +            if (st->codecpar->codec_type != AVMEDIA_TYPE_VIDEO)
> +                continue;
>              av_strlcpy(codec_str, os->codec_str, sizeof(codec_str));
> -            if ((st->codecpar->codec_type == AVMEDIA_TYPE_VIDEO) && max_audio_bitrate) {
> +            if (max_audio_bitrate) {
>                  agroup = (char *)audio_group;
>                  stream_bitrate += max_audio_bitrate;
>                  av_strlcat(codec_str, ",", sizeof(codec_str));
Pushed this patch. Thanks.
In spite of my original objections for supporting audio-only, I am pushing this patch as I am hearing reports of HLS master playlist generated being not playable in iOS devices due to this issue.
Hence pushing this patch becomes important for supporting basic HLS playback is more important than supporting audio-only HLS stream.

Regards,
Karthick