[FFmpeg-devel] [PATCH 3/3] h264/pic_timing: support multiple timecodes

[Carl Eugen Hoyos]

2018-10-11 15:04 GMT+02:00, Joshua de Kock <joshdk at ob-encoder.com>:
> On 9 October 2018 at 21:03, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>> 2018-10-09 15:32 GMT+02:00, joshdk at ob-encoder.com <joshdk at ob-encoder.com>:
>>> From: Josh de Kock <joshdk at obe.tv>
>>
>>> [...]
>>
>> If the first patch gets committed as-is, please split this one
>> in a functional and a cosmetic patch, above is unreviewable.
>>
>> Thank you, Carl Eugen
>
> I assume you mean split vf_showinfo out,

No.

> I had intended to do that but clearly I forgot so will do that.

> And why is it unreviewable?

It mixed white-space-only changes with functional changes
so that the original and the new lines get separated and make
the patch much more difficult to read than necessary.

Carl Eugen