[FFmpeg-devel] [PATCH]lavc/sinewin: Do not declare tables as const

[Carl Eugen Hoyos]

2018-10-19 20:35 GMT+02:00, Paul B Mahol <onemda at gmail.com>:
> On 10/19/18, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>> 2018-10-16 23:58 GMT+02:00, Carl Eugen Hoyos <ceffmpeg at gmail.com>:
>>> 2018-10-14 23:51 GMT+02:00, Carl Eugen Hoyos <ceffmpeg at gmail.com>:
>>>> 2018-10-14 22:30 GMT+02:00, Hendrik Leppkes <h.leppkes at gmail.com>:
>>>>> On Sun, Oct 14, 2018 at 10:18 PM Carl Eugen Hoyos <ceffmpeg at gmail.com>
>>>>> wrote:
>>>>>>
>>>>>> Attached patch is supposed to fix ticket #7491, I currently
>>>>>> don't have gcc 8 to test myself.
>>>>>
>>>>> Only the 120 and 960 tables are affected by this bug because
>>>>> they are not being created by the hardcoded tables logic, yet
>>>>> this patch changes the const attribute for all tables, defeating
>>>>> one purpose of the hardcoded tables.
>>>>
>>>>> Can we adjust this to only affect the two tables that need it
>>>>
>>>> Did that in attached patch, please comment.
>>>
>>> I will push this patch if there are no objections.
>>
>> Patch applied.
>
> Very ugly solution.

I don't disagree but keeping the hard-to-debug crash is not a
solution imo.

Carl Eugen