[FFmpeg-devel] avfilter : merge setfield and setrange and add set color property option

[Martin Vignali]

Le sam. 20 oct. 2018 à 18:18, Paul B Mahol <onemda at gmail.com> a écrit :

> On 10/20/18, Martin Vignali <martin.vignali at gmail.com> wrote:
> > Hello,
> >
> >>
> >> > Blocking this patch, no code should remove old filters.
> >> >
> >>
> > I suppose you talk about the proposal of removing setfield, setrange
> later ?
>
> It was not clear from commit log. So patches are fine for merge.
> Just missing documentation for new filter.
>
> >
> >
> >> > If you want more parameters to be changed write new filters instead.
> >> >
> >>
> > This is what the current patch do.
> >
>
> Yes.
>
> >
> >
> >>
> >> Feel free to merge code into single file and add another filter which
> >> would change more stuff at once instead of one filter which will
> >> change all values. Removing filters is bad.
> >>
> >
> > If i not miss something, this is what i do.
> >
> > I only keep setparams, because seems the right name for the filter i
> would
> > like to write
> > But setrange and setfield are keep, with the same behaviour
> >
> > Just call the same code in filter frame, (which change the param only if
> > the property is not set to auto (-1) (which is a default value for field,
> > range...)
>
> Yes, setparam is ok filter name.
>
>
New patch in attach
(add doc for setparams)

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avfilter-setparams-merge-setfield-and-setrange-filte.patch
Type: application/octet-stream
Size: 12522 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181020/73c7b334/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-avfilter-setparam-add-options-to-set-color-primaries.patch
Type: application/octet-stream
Size: 10229 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181020/73c7b334/attachment-0001.obj>